Skip to content

feat(query-builder): Make date filters more user friendly #72911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

malwilley
Copy link
Member

Instead of displaying is -24h, the actual search syntax is abstracted away:

age:-24h -> age is after 24h ago
age:+24h -> age is before 24h ago
age:>=2024-01-01 -> age is on or after 2024-01-01

When selecting an operator with equality ("is", "is on or after", etc), it will automatically switch to an ISO date string. Next step is to make that editable with a date picker component.

CleanShot 2024-06-17 at 15 40 47

CleanShot 2024-06-17 at 15 40 55

@malwilley malwilley requested a review from a team June 17, 2024 22:55
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 79.01235% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.05%. Comparing base (c0848c3) to head (9ef9bd3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72911   +/-   ##
=======================================
  Coverage   78.04%   78.05%           
=======================================
  Files        6605     6606    +1     
  Lines      294453   294499   +46     
  Branches    50762    50775   +13     
=======================================
+ Hits       229817   229868   +51     
+ Misses      58301    58296    -5     
  Partials     6335     6335           
Files Coverage Δ
...archQueryBuilder/filterValueParser/date/parser.tsx 100.00% <100.00%> (ø)
static/app/components/searchQueryBuilder/utils.tsx 88.88% <100.00%> (+0.48%) ⬆️
static/app/components/searchSyntax/utils.tsx 67.01% <100.00%> (+0.34%) ⬆️
...p/components/searchQueryBuilder/filterOperator.tsx 94.44% <88.88%> (-1.56%) ⬇️
...pp/components/searchQueryBuilder/valueCombobox.tsx 80.97% <88.46%> (+8.16%) ⬆️
...onents/searchQueryBuilder/useQueryBuilderState.tsx 68.62% <57.14%> (-4.35%) ⬇️

... and 1 file with indirect coverage changes

@malwilley malwilley merged commit 28928e1 into master Jun 18, 2024
43 checks passed
@malwilley malwilley deleted the malwilley/feat/search-query-builder-specific-date branch June 18, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants