Skip to content

ref(keyvaluedata): Change names and exports for better autocomplete #72939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

leeandher
Copy link
Member

Adds an explicit export to help with autocomplete (from a separate code review), and changes Group -> Container since the former has a meaning at Sentry.

@leeandher leeandher requested review from a team as code owners June 18, 2024 15:47
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (070a2b3) to head (4d35624).
Report is 41 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72939       +/-   ##
===========================================
- Coverage   88.20%   78.04%   -10.16%     
===========================================
  Files        2899     6604     +3705     
  Lines      180192   294433   +114241     
  Branches    32219    50763    +18544     
===========================================
+ Hits       158936   229789    +70853     
- Misses      15345    58307    +42962     
- Partials     5911     6337      +426     
Files Coverage Δ
...tic/app/components/events/contexts/contextCard.tsx 76.19% <100.00%> (ø)
.../components/events/contexts/contextDataSection.tsx 100.00% <ø> (ø)
static/app/components/keyValueData/index.tsx 85.00% <100.00%> (ø)
...nce/newTraceDetails/traceDrawer/details/styles.tsx 51.93% <100.00%> (ø)

... and 3701 files with indirect coverage changes

@leeandher leeandher merged commit 408d2d9 into master Jun 18, 2024
42 checks passed
@leeandher leeandher deleted the leander/keyvaluedata branch June 18, 2024 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants