ref(grouping): Rewrite hierarchical grouping tests #74144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
changed the base branch from
master
to
chore/move_tests/grouping/armenzg
armenzg
changed the base branch from
chore/move_tests/grouping/armenzg
to
master
armenzg
force-pushed
the
ref/hierachical_tests/armenzg
branch
from
cd36ba6 to
59a104d
Compare
armenzg
commented
Jul 11, 2024
| @@ -202,54 +202,18 @@ def test_partial_move(default_project, fast_save): | |||
|
|
|||
|
|
|||
| class EventManagerGroupingTest(TestCase): | |||
| def test_applies_secondary_grouping_hierarchical(self): | |||
There was a problem hiding this comment.
This is easier to review with the split view
| def test_applies_secondary_grouping_hierarchical(self): | ||
| project = self.project | ||
| project.update_option("sentry:grouping_config", "legacy:2019-03-12") | ||
| project.update_option("sentry:secondary_grouping_expiry", 0) |
There was a problem hiding this comment.
These 3 lines now live in the shared function set_options:
| project.update_option("sentry:grouping_config", "legacy:2019-03-12") | ||
| project.update_option("sentry:secondary_grouping_expiry", 0) | ||
|
|
||
| timestamp = time.time() - 300 |
There was a problem hiding this comment.
save_event will not use timestamp anymore.
|
|
||
| timestamp = time.time() - 300 | ||
|
|
||
| def save_event(ts_offset): |
There was a problem hiding this comment.
This function has been converted into a helper function. See down below.
| return manager.save(project.id) | ||
|
|
||
| event = save_event(0) | ||
| def test_can_upgrade_to_hierarchical_config(self): |
|
|
||
| project.update_option("sentry:grouping_config", "mobile:2021-02-12") | ||
| project.update_option("sentry:secondary_grouping_config", "legacy:2019-03-12") | ||
| project.update_option("sentry:secondary_grouping_expiry", time.time() + (24 * 90 * 3600)) |
There was a problem hiding this comment.
These 3 lines have been moved into a helper function.
| manager = EventManager( | ||
| make_event( | ||
| message="foo 123", | ||
| event_id=hex(2**127)[-32:], |
There was a problem hiding this comment.
Using the timestamp offset was not necessary. Two events can still have the same ID.
armenzg
force-pushed
the
ref/hierachical_tests/armenzg
branch
from
782bcf3 to
91c244c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74144 +/- ##
===========================================
+ Coverage 54.35% 78.20% +23.84%
===========================================
Files 5605 6660 +1055
Lines 236523 297354 +60831
Branches 40529 51176 +10647
===========================================
+ Hits 128566 232548 +103982
+ Misses 106482 58492 -47990
- Partials 1475 6314 +4839 |
snigdhas
approved these changes
Jul 11, 2024
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 13, 2024
This makes the tests a little easier to understand and prepares for my next set of changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests a little easier to understand and prepares for my next set of changes.