-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
ref(profiling) store unit on profile chart #74152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 537 bytes ⬆️
|
Zylphrex
approved these changes
Jul 12, 2024
Base automatically changed from
jb/profiling/render-continuous-profile
to
master
July 12, 2024 14:56
An error occurred while trying to automatically change base from
jb/profiling/render-continuous-profile
to
master
July 12, 2024 14:56
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74152 +/- ##
==========================================
- Coverage 78.11% 78.11% -0.01%
==========================================
Files 6661 6661
Lines 297737 297746 +9
Branches 51257 51259 +2
==========================================
+ Hits 232573 232578 +5
- Misses 58849 58853 +4
Partials 6315 6315
|
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 16, 2024
Since continuous profiles are in ms, we need to ensure the duration check is correctly computed based off the profile chart units
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since continuous profiles are in ms, we need to ensure the duration check is correctly computed based off the profile chart units