Skip to content

ref(profiling) store unit on profile chart #74152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jul 11, 2024

Since continuous profiles are in ms, we need to ensure the duration check is correctly computed based off the profile chart units

@JonasBa JonasBa requested a review from a team as a code owner July 11, 2024 17:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Bundle Report

Changes will increase total bundle size by 537 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.96MB 537 bytes ⬆️

Base automatically changed from jb/profiling/render-continuous-profile to master July 12, 2024 14:56
An error occurred while trying to automatically change base from jb/profiling/render-continuous-profile to master July 12, 2024 14:56
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (85148ec) to head (f9d3444).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74152      +/-   ##
==========================================
- Coverage   78.11%   78.11%   -0.01%     
==========================================
  Files        6661     6661              
  Lines      297737   297746       +9     
  Branches    51257    51259       +2     
==========================================
+ Hits       232573   232578       +5     
- Misses      58849    58853       +4     
  Partials     6315     6315              
Files Coverage Δ
...ents/profiling/flamegraph/continuousFlamegraph.tsx 0.00% <ø> (ø)
...app/components/profiling/flamegraph/flamegraph.tsx 51.47% <ø> (ø)
...omponents/profiling/flamegraph/flamegraphChart.tsx 57.84% <60.00%> (+2.28%) ⬆️
static/app/utils/profiling/flamegraphChart.tsx 22.64% <33.33%> (+0.64%) ⬆️
static/app/utils/profiling/units/units.ts 59.34% <25.00%> (-2.03%) ⬇️

@JonasBa JonasBa merged commit 296a2c9 into master Jul 15, 2024
42 of 43 checks passed
@JonasBa JonasBa deleted the jb/profiling/chart-rendering branch July 15, 2024 13:44
priscilawebdev pushed a commit that referenced this pull request Jul 16, 2024
Since continuous profiles are in ms, we need to ensure the duration
check is correctly computed based off the profile chart units
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants