Skip to content

fix(useFeedbackForm): Cleanup after form is closed or submitted #74163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

malwilley
Copy link
Member

Without these changes, the form after being closed still prevented the page from scrolling. I'm not sure if this is intended or is a bug with the SDK, but I was able to fix this by removing from the DOM when the form was closed or submitted.

@malwilley malwilley requested review from ryan953 and leeandher July 11, 2024 20:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (287eb32) to head (102ded2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74163      +/-   ##
==========================================
- Coverage   78.20%   78.20%   -0.01%     
==========================================
  Files        6660     6660              
  Lines      297379   297388       +9     
  Branches    51181    51182       +1     
==========================================
+ Hits       232554   232559       +5     
- Misses      58509    58513       +4     
  Partials     6316     6316              
Files Coverage Δ
static/app/utils/useFeedbackForm.tsx 85.18% <88.88%> (+1.85%) ⬆️

... and 5 files with indirect coverage changes

@malwilley malwilley requested a review from a team July 12, 2024 15:47
@malwilley malwilley merged commit 233ccd6 into master Jul 12, 2024
43 checks passed
@malwilley malwilley deleted the malwilley/fix/usefeedbackform-scroll branch July 12, 2024 15:49
priscilawebdev pushed a commit that referenced this pull request Jul 13, 2024
Without these changes, the form after being closed still prevented the
page from scrolling. I'm not sure if this is intended or is a bug with
the SDK, but I was able to fix this by removing from the DOM when the
form was closed or submitted.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants