Skip to content

fix(insights): minor bugs/improvements to empty states #74167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Jul 11, 2024

  1. Don't show extra filters on modules if there is no module data to begin with. For example on the assets module, we won't show the domain filter. This makes sense because these filters will not change anything in this context anyways.
  2. Use correct docs links from each modules settings.ts
  3. Remove duplicated read docs
  4. Don't show no query results banner in query module when no data has been sent to begin with.

@DominikB2014 DominikB2014 requested a review from a team as a code owner July 11, 2024 20:23
@DominikB2014 DominikB2014 requested a review from gggritso July 11, 2024 20:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (85148ec) to head (e4fa176).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #74167   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files        6661     6662    +1     
  Lines      297737   297749   +12     
  Branches    51257    51259    +2     
=======================================
+ Hits       232573   232586   +13     
+ Misses      58849    58847    -2     
- Partials     6315     6316    +1     
Files Coverage Δ
...s/browser/resources/views/resourcesLandingPage.tsx 100.00% <100.00%> (ø)
...s/browser/webVitals/views/webVitalsLandingPage.tsx 84.84% <100.00%> (+0.47%) ⬆️
...s/insights/common/components/modulesOnboarding.tsx 58.53% <ø> (ø)
...ws/insights/database/views/databaseLandingPage.tsx 75.60% <100.00%> (+0.60%) ⬆️
.../mobile/screenload/views/screenloadLandingPage.tsx 100.00% <100.00%> (ø)
static/app/views/insights/settings.ts 100.00% <ø> (ø)
...ights/mobile/common/components/screensTemplate.tsx 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

codecov bot commented Jul 12, 2024

Bundle Report

Changes will decrease total bundle size by 544 bytes ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 27.96MB 544 bytes ⬇️

@DominikB2014 DominikB2014 enabled auto-merge (squash) July 12, 2024 15:34
@DominikB2014 DominikB2014 merged commit 086f62a into master Jul 12, 2024
44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/empty-state-updates branch July 12, 2024 15:42
priscilawebdev pushed a commit that referenced this pull request Jul 13, 2024
1. Don't show extra filters on modules if there is no module data to
begin with. For example on the assets module, we won't show the domain
filter. This makes sense because these filters will not change anything
in this context anyways.
2. Use correct docs links from each modules `settings.ts`
3. Remove duplicated `read docs`
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants