-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(insights): minor bugs/improvements to empty states #74167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74167 +/- ##
=======================================
Coverage 78.11% 78.11%
=======================================
Files 6661 6662 +1
Lines 297737 297749 +12
Branches 51257 51259 +2
=======================================
+ Hits 232573 232586 +13
+ Misses 58849 58847 -2
- Partials 6315 6316 +1
|
gggritso
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Bundle ReportChanges will decrease total bundle size by 544 bytes ⬇️
|
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 13, 2024
1. Don't show extra filters on modules if there is no module data to begin with. For example on the assets module, we won't show the domain filter. This makes sense because these filters will not change anything in this context anyways. 2. Use correct docs links from each modules `settings.ts` 3. Remove duplicated `read docs`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings.ts
read docs