fix(query-builder): Send correct payload to value fetching endpoint when key is unknown #74172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen key is unknown
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 302 bytes ⬆️
|
snigdhas
approved these changes
Jul 11, 2024
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 13, 2024
…hen key is unknown (#74172) A small bug was caused because we do not enable `noUncheckedIndexedAccess` in our typescript config. We were keying into `filterKeys` with an unknown key and it returned undefined but the types did not reflect that. (This is an ongoing discussion in the frontend TSC but it's quite a bit of work to enable that config). This was fixed by providing a fallback when sending the key to `getTagValues()`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small bug was caused because we do not enable
noUncheckedIndexedAccessin our typescript config. We were keying intofilterKeyswith an unknown key and it returned undefined but the types did not reflect that. (This is an ongoing discussion in the frontend TSC but it's quite a bit of work to enable that config).This was fixed by providing a fallback when sending the key to
getTagValues().