feat(discover): Allows insight metrics to be used with the avg function in the discover metrics dataset #75870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on using insights related aggregates/queries
…er metrics dataset
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #75870 +/- ##
===========================================
- Coverage 90.49% 78.27% -12.22%
===========================================
Files 3099 6824 +3725
Lines 193934 303942 +110008
Branches 0 52287 +52287
===========================================
+ Hits 175504 237918 +62414
- Misses 18430 59635 +41205
- Partials 0 6389 +6389 |
…er' of github.com:getsentry/sentry into egou/feat/discover-metrics-avg-allow-insight-metrics
…er' of github.com:getsentry/sentry into egou/feat/discover-metrics-avg-allow-insight-metrics
Base automatically changed from
egou/feat/insights-entity-subscription-skip-metrics-layer
to
master
August 12, 2024 15:15
…iscover-metrics-avg-allow-insight-metrics
DominikB2014
approved these changes
Aug 12, 2024
edwardgou-sentry
deleted the
egou/feat/discover-metrics-avg-allow-insight-metrics
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows insights metrics (eg: span.self_time) to be used in the metrics avg function