fix(custom-views): editableTabTitle Improvements #76247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Aug 15, 2024
MichaelSun48
added a commit
that referenced
this pull request
Aug 16, 2024
…lag (#75883) This PR releases the custom views feature into the issue stream under a feature flag. Flagged users will also see the "Custom Search" button has been removed from the issue stream in favor of custom views. The bulk of this new component exists in `<CustomViewsIssueListHeader/>`, whose parent component is in overview.tsx. Several changes have also been made to the base draggable tab components to iron out any compatibility issues that did not appear during sandbox development. Things that are still broken that I am actively working on: * ~Tab Renaming is both ugly and broken (can't type in spaces)~ (#76247) * Tab overflow logic does not exist at all * QueryCounts do not work for any tabs with queries that do not match queries of previous default tabs * Some queries that are functionally the same but off by a space register as different, thus triggering the "unsaved changes" state. * Tabs do not animate in when added, nor do they animate out when deleted * No loading or failure state for tabs request * ~Stories is busted as a result of all of the changes made to base tabs components~ (deleted stories, this component is not, and was not meant to be reusable)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component makes some important improvements to the editableTabTitle component, which is used in custom views to allow users to rename the titles of their tabs. These fixes include:
Screen.Recording.2024-08-14.at.5.27.48.PM.mov