ref(tabs): Refactor to separate TabStateProvider from the TabsWrap styles #77175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Sep 9, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
c298lee
pushed a commit
that referenced
this pull request
Sep 10, 2024
…yles (#77175) I need to separate the state from the styles because the styles are difficult to use inside a flex/grid system. For the hydration error diff modal I need to insert some other css in there, and the api to override TabsWrap seemed more hacky than simply setting what's needed directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to separate the state from the styles because the styles are difficult to use inside a flex/grid system.
For the hydration error diff modal I need to insert some other css in there, and the api to override TabsWrap seemed more hacky than simply setting what's needed directly.