Skip to content

chore(similarity): Add longer snuba delay in backfill #77583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

jangjodi
Copy link
Contributor

Increase delay between snuba calls in similarity backfill to help with snuba ratelimit being hit
Add worker number to log so we can more easily query which worker numbers are running in backfill

@jangjodi jangjodi requested a review from a team as a code owner September 16, 2024 19:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 16, 2024
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's increase retry too?

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77583      +/-   ##
==========================================
+ Coverage   78.10%   78.11%   +0.01%     
==========================================
  Files        6966     6965       -1     
  Lines      309334   309190     -144     
  Branches    50636    50608      -28     
==========================================
- Hits       241599   241536      -63     
+ Misses      61337    61254      -83     
- Partials     6398     6400       +2     

@jangjodi jangjodi merged commit a517de5 into master Sep 17, 2024
50 checks passed
@jangjodi jangjodi deleted the jodi/similarity-backfill-snuba-delay branch September 17, 2024 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants