Skip to content

fix(issue-stream): Fix bug where replay divider was shown despite no replays #79068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(issue-stream): Fix bug where replay divider was shown despite no replays #79068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa609e
Fix bug where replay divider was shown despite no replays
MichaelSun48 Oct 11, 2024
044d8f8
Fix showreplay count bool
MichaelSun48 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion static/app/components/eventOrGroupExtraDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import type {Group} from 'sentry/types/group';
import type {Organization} from 'sentry/types/organization';
import {defined} from 'sentry/utils';
import {getTitle} from 'sentry/utils/events';
import useReplayCountForIssues from 'sentry/utils/replayCount/useReplayCountForIssues';
import {projectCanLinkToReplay} from 'sentry/utils/replays/projectSupportsReplay';
import withOrganization from 'sentry/utils/withOrganization';

Expand Down Expand Up @@ -73,10 +74,13 @@ function EventOrGroupExtraDetails({
} = data as Group;

const issuesPath = `/organizations/${organization.slug}/issues/`;
const {getReplayCountForIssue} = useReplayCountForIssues();

const showReplayCount =
organization.features.includes('session-replay') &&
projectCanLinkToReplay(organization, project);
projectCanLinkToReplay(organization, project) &&
data.issueCategory &&
!!getReplayCountForIssue(data.id, data.issueCategory);

const hasNewLayout = organization.features.includes('issue-stream-table-layout');
const {subtitle} = getTitle(data);
Expand Down
Loading