ref(grouping): Small refactor of the GroupingComponent class
#80723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
reviewed
Nov 14, 2024
JoshFerge
approved these changes
Nov 14, 2024
Base automatically changed from
kmclb-remove-salt-wrappers-in-legacy-config
to
master
November 14, 2024 22:02
lobsterkatie
force-pushed
the
kmclb-prepare-grouping-component-for-subclassing
branch
from
d353302 to
1d00bd0
Compare
lobsterkatie
deleted the
kmclb-prepare-grouping-component-for-subclassing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few small changes to the
GroupingComponentclass, in preparation for the creation of a more detailed taxonomy of subclasses, which will happen in #80722.GroupingComponent) in__repr__.intto thevalueslist type. (This is more of a bug fix, though it's also a necessary for the upcoming changes. In fact,valueshas always been able to contain ints, but the incoming data isn't super strictly typed, so typechecking has passed even with this missing.)__init__.