ref(grouping): Simplify security report grouping strategies #80726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Nov 14, 2024
lobsterkatie
force-pushed
the
kmclb-rename-grouping-component-to-base-grouping-component
branch
from
c48f3b8 to
0992798
Compare
lobsterkatie
force-pushed
the
kmclb-stop-using-helper-for-security-grouping-strategies
branch
from
122625d to
d4b38fe
Compare
lobsterkatie
force-pushed
the
kmclb-rename-grouping-component-to-base-grouping-component
branch
from
0992798 to
08d64ab
Compare
lobsterkatie
force-pushed
the
kmclb-stop-using-helper-for-security-grouping-strategies
branch
from
d4b38fe to
aa7ffe8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80726 +/- ##
=======================================
Coverage 78.39% 78.39%
=======================================
Files 7207 7207
Lines 319517 319515 -2
Branches 44005 44005
=======================================
+ Hits 250490 250492 +2
+ Misses 62639 62637 -2
+ Partials 6388 6386 -2 |
lobsterkatie
force-pushed
the
kmclb-rename-grouping-component-to-base-grouping-component
branch
from
08d64ab to
9c6cb8a
Compare
lobsterkatie
force-pushed
the
kmclb-stop-using-helper-for-security-grouping-strategies
branch
from
aa7ffe8 to
5c93d6b
Compare
Base automatically changed from
kmclb-rename-grouping-component-to-base-grouping-component
to
master
November 15, 2024 15:20
lobsterkatie
force-pushed
the
kmclb-stop-using-helper-for-security-grouping-strategies
branch
from
5c93d6b to
afa4134
Compare
lobsterkatie
deleted the
kmclb-stop-using-helper-for-security-grouping-strategies
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the non-CSP security-related grouping strategies, to no longer require a helper function but instead just return their requisite components directly. (Basically, each one now inlines the helper's return value.) Doing this will allow each one to return a different subclass of
BaseGroupingComponent, as will be done in #80722.