feat(relocation): Add GCP-backed export checkpointer #80803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
commented
Nov 15, 2024
Comment on lines
-218
to
-221
| @abstractmethod | ||
| def read(self) -> bytes: | ||
| pass | ||
|
|
There was a problem hiding this comment.
All changes to this file remove an unused method.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #80803 +/- ##
=======================================
Coverage 74.97% 74.97%
=======================================
Files 7207 7207
Lines 319509 319501 -8
Branches 44001 44001
=======================================
- Hits 239546 239541 -5
+ Misses 73442 73439 -3
Partials 6521 6521 |
This builds on the work of #80711 to add a GCP-backed `ExportCheckpointer` implementation. Now, when exporting, we save (always encrypted!) copies of the progress on each model kind seen so far. If the export fails halfway through, we can use these checkpoints to recover much more quickly then if we had to redo all of that work, ensuring a higher chance of success on the retry.
azaslavsky
force-pushed
the
azaslavsky/gcp-export-checkpointer
branch
from
d9af536 to
7e75bca
Compare
| if parsed_json is None: | ||
| logger.info( | ||
| "Export checkpointer: miss", | ||
| extra=logger_data, |
There was a problem hiding this comment.
Just wanted to sanity check: There will be no sensitive data exposed here?
There was a problem hiding this comment.
Nope: just the name of the model, the UUID of the relocation (safe), and the size (in bytes) of the encrypted data used in the checkpoint. None of that is sensitive.
hubertdeng123
approved these changes
Nov 18, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work of #80711 to add a GCP-backed
ExportCheckpointerimplementation. Now, when exporting, we save (always encrypted!) copies of the progress on each model kind seen so far. If the export fails halfway through, we can use these checkpoints to recover much more quickly then if we had to redo all of that work, ensuring a higher chance of success on the retry.