ref(replay): Refactor extractDomNodes stepper strategy into extractDomNodes.tsx #80810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
added a commit
that referenced
this pull request
Nov 15, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80810 +/- ##
==========================================
+ Coverage 74.97% 78.40% +3.42%
==========================================
Files 7207 7207
Lines 319509 319508 -1
Branches 44001 44001
==========================================
+ Hits 239546 250504 +10958
+ Misses 73442 62624 -10818
+ Partials 6521 6380 -141 |
billyvg
approved these changes
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to move this replayStepper strategy outside of the ReplayReader class. It's a big file that contains the class, and most of the other stepper stuff isn't in here.