Skip to content

feat(sdk): Upgrade @sentry SDKs to v8.43.0 #81925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-utils/sentry-instrumentation.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-env node */
import type {Span} from '@sentry/core';
import type * as Sentry from '@sentry/node';
import type {Span} from '@sentry/types';
import crypto from 'node:crypto';
import https from 'node:https';
import os from 'node:os';
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@
"@sentry-internal/rrweb": "2.26.0",
"@sentry-internal/rrweb-player": "2.26.0",
"@sentry-internal/rrweb-snapshot": "2.26.0",
"@sentry/core": "8.39.0-beta.0",
"@sentry/node": "8.39.0-beta.0",
"@sentry/react": "8.39.0-beta.0",
"@sentry/core": "8.43.0",
"@sentry/node": "8.43.0",
"@sentry/react": "8.43.0",
"@sentry/release-parser": "^1.3.1",
"@sentry/status-page-list": "^0.3.0",
"@sentry/types": "8.39.0-beta.0",
"@sentry/utils": "8.39.0-beta.0",
"@sentry/types": "8.43.0",
"@sentry/utils": "8.43.0",
"@sentry/webpack-plugin": "^2.22.4",
"@spotlightjs/spotlight": "^2.0.0-alpha.1",
"@tanstack/react-query": "^5.56.2",
Expand Down Expand Up @@ -179,7 +179,7 @@
"@emotion/eslint-plugin": "^11.12.0",
"@pmmmwh/react-refresh-webpack-plugin": "0.5.15",
"@sentry/jest-environment": "6.0.0",
"@sentry/profiling-node": "8.39.0-beta.0",
"@sentry/profiling-node": "8.43.0",
"@styled/typescript-styled-plugin": "^1.0.1",
"@testing-library/dom": "10.1.0",
"@testing-library/jest-dom": "6.4.5",
Expand Down
3 changes: 1 addition & 2 deletions static/app/bootstrap/initializeSdk.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// eslint-disable-next-line simple-import-sort/imports
import * as Sentry from '@sentry/react';
import {_browserPerformanceTimeOriginMode} from '@sentry/utils';
import type {Event} from '@sentry/types';
import {type Event, _browserPerformanceTimeOriginMode} from '@sentry/core';

import {SENTRY_RELEASE_VERSION, SPA_DSN} from 'sentry/constants';
import type {Config} from 'sentry/types/system';
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/badge/featureBadge.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {Fragment, type ReactNode} from 'react';
import {useTheme} from '@emotion/react';
import styled from '@emotion/styled';
import type {SeverityLevel} from '@sentry/core';
import {captureException, withScope} from '@sentry/react';
import type {SeverityLevel} from '@sentry/types';

import Badge from 'sentry/components/badge/badge';
import CircleIndicator from 'sentry/components/circleIndicator';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {useCallback, useEffect, useState} from 'react';
import type {ReplayRecordingMode} from '@sentry/core';
import type {replayIntegration} from '@sentry/react';
import type {ReplayRecordingMode} from '@sentry/types';

import useConfiguration from 'sentry/components/devtoolbar/hooks/useConfiguration';
import {useSessionStorage} from 'sentry/utils/useSessionStorage';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {Client, Scope} from '@sentry/types';
import type {Client, Scope} from '@sentry/core';

type V8Carrier = {
stack: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {Event} from '@sentry/types';
import type {Event} from '@sentry/core';

import {useApiQuery} from 'sentry/utils/queryClient';
import useOrganization from 'sentry/utils/useOrganization';
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/featureFeedback/feedbackModal.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import {Fragment, useCallback, useMemo, useState} from 'react';
import {css, useTheme} from '@emotion/react';
import styled from '@emotion/styled';
import type {Event} from '@sentry/core';
import {
BrowserClient,
captureFeedback,
defaultStackParser,
getDefaultIntegrations,
makeFetchTransport,
} from '@sentry/react';
import type {Event} from '@sentry/types';
import cloneDeep from 'lodash/cloneDeep';

import {addSuccessMessage} from 'sentry/actionCreators/indicator';
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/feedback/widget/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {Event} from '@sentry/types';
import type {Event} from '@sentry/core';

/**
* NOTE: These types are still considered Beta and subject to change.
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/group/externalIssueForm.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {Span} from '@sentry/core';
import * as Sentry from '@sentry/react';
import type {Span} from '@sentry/types';

import {addSuccessMessage} from 'sentry/actionCreators/indicator';
import type DeprecatedAsyncComponent from 'sentry/components/deprecatedAsyncComponent';
Expand Down
2 changes: 1 addition & 1 deletion static/app/types/event.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {CloudResourceContext} from '@sentry/types';
import type {CloudResourceContext} from '@sentry/core';

import type {CultureContext} from 'sentry/components/events/contexts/knownContext/culture';
import type {MissingInstrumentationContext} from 'sentry/components/events/contexts/knownContext/missingInstrumentation';
Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/analytics.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {Span} from '@sentry/core';
import * as Sentry from '@sentry/react';
import type {Span} from '@sentry/types';

import HookStore from 'sentry/stores/hookStore';
import type {Hooks} from 'sentry/types/hooks';
Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/featureObserver.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {FeatureFlagContext} from '@sentry/types/build/types/context';
import type {FeatureFlagContext} from '@sentry/core/build/types/types-hoist/context';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be

Suggested change
import type {FeatureFlagContext} from '@sentry/core/build/types/types-hoist/context';
import type {FeatureFlagContext} from '@sentry/core';

Copy link
Member Author

@aliu39 aliu39 Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an error importing directly, this is from vscode autocomplete. Looks like it's not exported in index

Copy link
Member

@billyvg billyvg Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure this gets exported and updated, we shouldn't rely on importing from this

import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/performanceForSentry/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type {ProfilerOnRenderCallback, ReactNode} from 'react';
import {Fragment, Profiler, useEffect, useRef} from 'react';
import type {MeasurementUnit, Span, TransactionEvent} from '@sentry/core';
import * as Sentry from '@sentry/react';
import type {MeasurementUnit, Span, TransactionEvent} from '@sentry/types';
import {
_browserPerformanceTimeOriginMode,
browserPerformanceTimeOrigin,
Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/profiling/profile/importProfile.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {Span} from '@sentry/core';
import * as Sentry from '@sentry/react';
import type {Span} from '@sentry/types';

import type {Image} from 'sentry/types/debugImage';

Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/profiling/profile/utils.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {Span} from '@sentry/core';
import * as Sentry from '@sentry/react';
import type {Span} from '@sentry/types';

import {defined} from 'sentry/utils';
import type {FlamegraphFrame} from 'sentry/utils/profiling/flamegraphFrame';
Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/useFeedbackForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
useEffect,
useRef,
} from 'react';
import type {FeedbackModalIntegration} from '@sentry/types';
import type {FeedbackModalIntegration} from '@sentry/core';

import {
useFeedback,
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/routeError.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {useEffect} from 'react';
import styled from '@emotion/styled';
import type {Scope} from '@sentry/core';
import * as Sentry from '@sentry/react';
import type {Scope} from '@sentry/types';

import {getLastEventId} from 'sentry/bootstrap/initializeSdk';
import {Alert} from 'sentry/components/alert';
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/featureFlags/useUserFromId.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {User} from '@sentry/types';
import type {User} from '@sentry/core';

import {useApiQuery} from 'sentry/utils/queryClient';
import useOrganization from 'sentry/utils/useOrganization';
Expand Down
Loading
Loading