✨ feat(aci): add discord/msteam issue alert migration helper #83455
Conversation
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83455 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.02%
==========================================
Files 9405 9405
Lines 537144 537514 +370
Branches 21136 21136
==========================================
+ Hits 470120 470572 +452
+ Misses 66673 66591 -82
Partials 351 351 |
| # Remove excluded keys | ||
| return {k: v for k, v in self.action.items() if k not in EXCLUDED_ACTION_DATA_KEYS} | ||
| # Remove excluded keys and required fields | ||
| excluded_keys = EXCLUDED_ACTION_DATA_KEYS + self.required_fields |
There was a problem hiding this comment.
are all required fields guaranteed to be stored as fields on Action?
There was a problem hiding this comment.
yes, required fields are the ones stores in integration_id, target_identifier, target_display
There was a problem hiding this comment.
should there be some kind of assert for this?
we will only migrate the valid ones |
| # Remove excluded keys | ||
| return {k: v for k, v in self.action.items() if k not in EXCLUDED_ACTION_DATA_KEYS} | ||
| # Remove excluded keys and required fields | ||
| excluded_keys = EXCLUDED_ACTION_DATA_KEYS + self.required_fields |
There was a problem hiding this comment.
should there be some kind of assert for this?
we assert here: |
continues #83123, adding migration helper utils for discord and msteams.
updated the base class a bit so it returns None by default for optional fields. also fixed a tiny bug in the base class blob sanitize function so i also remove the required attributes (since they are part of the first-class fields (
integration_id,target_identifier, etc.) on the model)MsTeams doesn't have a dataclass defined b/c we won't have anything special saved in data blob.