-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(dashboards): Namespaced Widget
components
#85238
ref(dashboards): Namespaced Widget
components
#85238
Conversation
This makes it more discoverable and easier to find and use without extra imports.
Again, discoverability, ease.
Those ones weren't doing enough work to justify themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much prefer this sort of API, a bit more tedious to write, but easier to follow, understand, and ultimately a lot more flexible too!
static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgets/bigNumberWidget/bigNumberWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgets/bigNumberWidget/bigNumberWidget.tsx
Outdated
Show resolved
Hide resolved
Add some prefixes to disambiguate
@JonasBa makes sense! I'm not very sensitive to polluting autocomplete since it also includes the paths, but I agree that for very generic names like "Toolbar" this is a good idea. I think I address your naming suggestions wholesale, but let me know if I missed anything 🙏🏻 |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @gggritso
A big re-structure of the components that make up our standard widgets. Improves clarity (simpler component names), removed junk (single-use components that don't need their own files) reduces the number of imports (components are namespaced), and adds more documentation.
Changes
There are a few changes in this PR, all linked together. The easiest way to explain them is in context, so here's an example, taken straight from the new documentation: