Skip to content

ref: get_group_{body,title,description} to not need request #85263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/sentry/plugins/bases/issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,23 @@ class IssueTrackingPlugin(Plugin):
def get_plugin_type(self):
return "issue-tracking"

def _get_group_body(self, request: Request, group, event, **kwargs):
def _get_group_body(self, group, event, **kwargs):
result = []
for interface in event.interfaces.values():
output = safe_execute(interface.to_string, event)
if output:
result.append(output)
return "\n\n".join(result)

def _get_group_description(self, request: Request, group, event):
def _get_group_description(self, group, event):
referrer = self.get_conf_key() + "_plugin"
output = [absolute_uri(group.get_absolute_url(params={"referrer": referrer}))]
body = self._get_group_body(request, group, event)
body = self._get_group_body(group, event)
if body:
output.extend(["", "```", body, "```"])
return "\n".join(output)

def _get_group_title(self, request: Request, group, event):
def _get_group_title(self, group, event):
return event.title

def is_configured(self, project) -> bool:
Expand Down Expand Up @@ -135,8 +135,8 @@ def link_issue(self, request: Request, group, form_data, **kwargs):

def get_initial_form_data(self, request: Request, group, event, **kwargs):
return {
"description": self._get_group_description(request, group, event),
"title": self._get_group_title(request, group, event),
"description": self._get_group_description(group, event),
"title": self._get_group_title(group, event),
}

def has_auth_configured(self, **kwargs):
Expand Down
12 changes: 6 additions & 6 deletions src/sentry/plugins/bases/issue2.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,23 +101,23 @@ def get_plugin_type(self):
def has_project_conf(self):
return True

def get_group_body(self, request: Request, group, event, **kwargs):
def get_group_body(self, group, event, **kwargs):
result = []
for interface in event.interfaces.values():
output = safe_execute(interface.to_string, event)
if output:
result.append(output)
return "\n\n".join(result)

def get_group_description(self, request: Request, group, event):
def get_group_description(self, group, event):
referrer = self.get_conf_key() + "_plugin"
output = [absolute_uri(group.get_absolute_url(params={"referrer": referrer}))]
body = self.get_group_body(request, group, event)
body = self.get_group_body(group, event)
if body:
output.extend(["", "```", body, "```"])
return "\n".join(output)

def get_group_title(self, request: Request, group, event):
def get_group_title(self, group, event):
return event.title

def is_configured(self, project) -> bool:
Expand Down Expand Up @@ -172,13 +172,13 @@ def get_new_issue_fields(self, request: Request, group, event, **kwargs):
{
"name": "title",
"label": "Title",
"default": self.get_group_title(request, group, event),
"default": self.get_group_title(group, event),
"type": "text",
},
{
"name": "description",
"label": "Description",
"default": self.get_group_description(request, group, event),
"default": self.get_group_description(group, event),
"type": "textarea",
},
]
Expand Down
4 changes: 2 additions & 2 deletions src/sentry_plugins/jira/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ def is_configured(self, project) -> bool:
return False
return True

def get_group_description(self, request: Request, group, event):
def get_group_description(self, group, event):
# mostly the same as parent class, but change ``` to {code}
output = [absolute_uri(group.get_absolute_url(params={"referrer": "jira_plugin"}))]
body = self.get_group_body(request, group, event)
body = self.get_group_body(group, event)
if body:
output.extend(["", "{code}", body, "{code}"])
return "\n".join(output)
Expand Down
8 changes: 4 additions & 4 deletions src/sentry_plugins/redmine/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ def get_new_issue_title(self, **kwargs):

def get_initial_form_data(self, request: Request, group, event, **kwargs):
return {
"description": self._get_group_description(request, group, event),
"title": self._get_group_title(request, group, event),
"description": self._get_group_description(group, event),
"title": self._get_group_title(group, event),
}

def _get_group_description(self, request: Request, group, event):
def _get_group_description(self, group, event):
output = [absolute_uri(group.get_absolute_url())]
body = self._get_group_body(request, group, event)
body = self._get_group_body(group, event)
if body:
output.extend(["", "<pre>", body, "</pre>"])
return "\n".join(output)
Expand Down
Loading