ref(seer grouping): Add ability to ignore useless filenames #85277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
Feb 14, 2025
| stacktrace_string = get_stacktrace_string(exception) | ||
| assert ( | ||
| stacktrace_string | ||
| == 'ZeroDivisionError: division by zero\n File "None", function divide_by_zero\n divide = 1/0' |
lobsterkatie
deleted the
kmclb-ignore-compiler-generated-filename-in-seer-stacktrace-string
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer recently switched the build tool for their iOS app, and it changed their app's stacktraces such that new groups are now being created when ideally they wouldn't be. There were multiple differences in the stacktraces, not all easily mitigated, but one straightforward one was that some frames went from having no filename property to having a filename property of
<compiler-generated>.To make it so that at least Seer will ignore this particular difference, this PR adds a list of filenames for us to ignore when constructing the stacktrace string we send it. We should also consider marking filename components with such filenames as non-contributing, but that will have to wait for a separate PR.