ref(derived_code_mappings): Simplify FrameFilename #85981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes included: * Remove some unused properties * Unify code that transforms the file path
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Feb 26, 2025
| @@ -12,7 +12,7 @@ | |||
| from sentry.integrations.base import IntegrationFeatures | |||
| from sentry.integrations.manager import default_manager as integrations | |||
| from sentry.integrations.services.integration import RpcIntegration, integration_service | |||
| from sentry.issues.auto_source_code_config.code_mapping import FrameFilename, find_roots | |||
| from sentry.issues.auto_source_code_config.code_mapping import FrameInfo, find_roots | |||
There was a problem hiding this comment.
I'm renaming the class as it does not just hold a modified frame filename.
| frame_file_path = frame_file_path.replace("\\", "/") | ||
|
|
||
| if frame_file_path[0] == "/" or frame_file_path[0] == "\\": | ||
| frame_file_path = frame_file_path[1:] |
There was a problem hiding this comment.
I'm moving this block above within the transformations function.
|
|
||
| self.full_path = frame_file_path |
There was a problem hiding this comment.
Removing it as it's only used within this module:
https://github.com/search?q=repo%3Agetsentry%2Fsentry+.full_path+path%3A%22src%2Fsentry%2Fissues%2F%22&type=code
|
|
||
| self.full_path = frame_file_path | ||
| self.extension = get_extension(frame_file_path) |
| # windows drive letters can be like C:\ or C: | ||
| # so we need to remove the slash if it exists | ||
| if frame_file_path[0] == "/": | ||
| frame_file_path = frame_file_path[1:] |
There was a problem hiding this comment.
Moved within the transformations function.
| start_at_index = get_straight_path_prefix_end_index(frame_file_path) | ||
| self.straight_path_prefix = frame_file_path[:start_at_index] |
| if start_at_index == 0: | ||
| self.root = frame_file_path.split("/")[0] | ||
| self.stack_root = frame_file_path.split("/")[0] |
There was a problem hiding this comment.
Renaming it to something more meaningful.
| self.root = frame_file_path[0:slash_index] | ||
| self.stack_root = frame_file_path[0:slash_index] | ||
|
|
||
| def transformations(self, frame_file_path: str) -> str: |
There was a problem hiding this comment.
Copy pasted unchanged from two blocks in the __init__ function.
tests/sentry/issues/auto_source_code_config/test_code_mapping.py
Outdated
Show resolved
Hide resolved
MichaelSun48
approved these changes
Feb 27, 2025
MichaelSun48
approved these changes
Feb 27, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
ameliahsu
pushed a commit
that referenced
this pull request
Mar 5, 2025
Changes included: * Remove some unused properties * Unify code that transforms the file path
armenzg
added this to the Automate Code Mappings & In-App Stack Trace Rules for Java projects milestone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included: