feat(derive_code_mapping): Pass platform around the code base #86026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for the Java in-app work.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Feb 27, 2025
| def __init__(self, frame: Mapping[str, Any]) -> None: | ||
| # XXX: In the next PR, we will use more than just the filename | ||
| def __init__(self, frame: Mapping[str, Any], platform: str | None = None) -> None: | ||
| # XXX: platform will be used in a following PR |
| @@ -37,9 +37,6 @@ def get_stacktraces(data: NodeData | dict[str, Any]) -> list[dict[str, Any]]: | |||
| if exceptions: | |||
| return [e["stacktrace"] for e in exceptions if get_path(e, "stacktrace", "frames")] | |||
|
|
|||
| stacktrace = data.get("stacktrace") | |||
| if stacktrace and stacktrace.get("frames"): | |||
| logger.warning("Investigate if we use this code path in production.") | |||
There was a problem hiding this comment.
This warning is nowhere to be found in Sentry, thus, simplifying this.
snigdhas
approved these changes
Feb 27, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
armenzg
added this to the Automate Code Mappings & In-App Stack Trace Rules for Java projects milestone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the Java in-app work.