feat(issue-views): Improve drag handle and safari interactions #87119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
commented
Mar 14, 2025
| @@ -45,7 +44,6 @@ const IconWrap = styled('div')` | |||
| flex-direction: column; | |||
| align-items: center; | |||
| justify-content: center; | |||
| margin-right: ${space(0.75)}; | |||
There was a problem hiding this comment.
The project icon should not have an opinion on margin
MichaelSun48
commented
Mar 14, 2025
malwilley
approved these changes
Mar 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of minor improvements to issue views, specifically related to the newly added grab handle, and safari improvements:
Note that there is still an issue where triggering a reorder while dragging in safari will cause the hover state to be lost. This seems to be an intentional decision by Safari, but I could not figure out a reasonable fix in the timebox I gave myself.