Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-consent): Fix non touch customers seeing msa prompt #87133

Merged
merged 2 commits into from
Mar 14, 2025
Merged

fix(data-consent): Fix non touch customers seeing msa prompt #87133

merged 2 commits into from
Mar 14, 2025

Conversation

jennmueng
Copy link
Member

Non touch customers were seeing the MSA guard, this should fix that.

@jennmueng jennmueng requested a review from roaga March 14, 2025 21:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 14, 2025
roaga
roaga approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand how changing the variable names fixes this but i trust you

@jennmueng
Copy link
Member Author

@roaga it's a different field from useGenAiConsentButtonAccess

@jennmueng jennmueng merged commit a836c55 into master Mar 14, 2025
41 checks passed
@jennmueng jennmueng deleted the jenn/gs/fix-data-consent branch March 14, 2025 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roaga roaga roaga approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennmueng @roaga