Skip to content

chore(rpc): Remove querying EAP via snql #89422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wmak
Copy link
Member

@wmak wmak commented Apr 11, 2025

  • the useRpc Param used with dataset=spans allows the frontend to choose between querying via rpc or snql
  • this should be a no-op since even if the frontend wasn't passing useRpc and hitting eap via snql should work via rpc

- the useRpc Param used with dataset=spans allows the frontend to choose
  between querying via rpc or snql
- this should be a no-op since even if the frontend wasn't passing
  useRpc and hitting eap via snql should work via rpc
@wmak wmak requested review from a team as code owners April 11, 2025 19:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 11, 2025
@wmak wmak requested review from a team as code owners April 11, 2025 19:54
Copy link

codecov bot commented Apr 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
330 1 329 11
View the top 1 failed test(s) by shortest run time
::tests.sentry.integrations.slack.test_unfurl
Stack Traces | 0s run time
#x1B[31mImportError while importing test module '.../integrations/slack/test_unfurl.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/importlib/__init__.py#x1B[0m:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
#x1B[1m#x1B[.../integrations/slack/test_unfurl.py#x1B[0m:18: in <module>
    from sentry.snuba import discover, errors, spans_eap, transactions
#x1B[1m#x1B[31mE   ImportError: cannot import name 'spans_eap' from 'sentry.snuba' (.../sentry/snuba/__init__.py)#x1B[0m#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant