-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
ref(py): Normalize deletions load_defaults imports #89440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(py): Normalize deletions load_defaults imports #89440
Conversation
easiest to look at how it looks after sentry/src/sentry/deletions/__init__.py Lines 92 to 179 in b96263c
|
__all__ = ( | ||
"AlertRule", | ||
"AlertRuleActivity", | ||
"AlertRuleTrigger", | ||
"AlertRuleTriggerAction", | ||
"Incident", | ||
) | ||
|
||
from .alert_rule import AlertRule, AlertRuleActivity, AlertRuleTrigger, AlertRuleTriggerAction | ||
from .incident import Incident |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these import changes? Seems a bit unnecessary, especially since these are going away
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to keep the way deletion models are imported consistent
I know we're trying to just straight remove these, but let's at least be consistent for now so that mypy understands that these models are available from this module. Needed for this simplification #89440
b96263c
to
8c2e748
Compare
I know we're trying to just straight remove these, but let's at least be consistent for now so that mypy understands that these models are available from this module. Needed for this simplification #89440
No description provided.