fix(aci milestone 3): separate flag for processing metric issue workflows #89443
+37
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
reviewed
Apr 11, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #89443 +/- ##
==========================================
- Coverage 87.70% 86.50% -1.20%
==========================================
Files 10144 10147 +3
Lines 573277 573364 +87
Branches 22525 22525
==========================================
- Hits 502811 496015 -6796
- Misses 70032 76915 +6883
Partials 434 434 |
saponifi3d
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gating processing of both metric issues and errors with one flag was causing problems if an org was flagged into metric detectors but not error detectors (or vice versa). Add a separate flag for metric issues.