fix(alerts): Don't group on time #89447
Draft
+148
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
commented
Apr 11, 2025
| referrer_suffix=referrer_suffix, | ||
| ) | ||
| result: Mapping[int, int] = {} | ||
| if tsdb_function == tsdb.get_sums: |
There was a problem hiding this comment.
I didn't want to add group_on_time to the other tsdb functions we may pass since they don't use it anyway, but this feels a little hacky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blah blah fill this in later but if we hit the bucket limit (10,000) we'll just drop additional results and have incorrect data