ref(feedback): extract utils and shim code from create_feedback #89458
+213
−198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves code from create_feedback.py to new files in the feedback module. This makes the file more manageable, and also allows imports between
create_feedback
(feedback consumer code) andingest/userreport.py
(the entrypoint for ingesting UR's/legacy feedback). See https://develop.sentry.dev/application-architecture/feedback-architecture/ for the full ingest pipeline.Right now importing
save_userreport
fromcreate_feedback.py
leads to a circular import. We need this for incoming work to link new feedbacks from issue details. Extractingshim_to_feedback
and making a sharedlib/
will fix this problem, and help w/future maintenance. We shouldn't have as much dependence oncreate_feedback.py
as we do now.Details of changes:
Moved from
feedback.usecases.create_feedback
tofeedback.lib.utils
:FeedbackCreationSource
enumUNREAL_FEEDBACK_UNATTENDED_MESSAGE
constantis_in_feedback_denylist
utilMoved from
feedback.usecases.create_feedback
tofeedback.usecases.shim_to_feedback
:shim_to_feedback
, helper for porting legacy format to the new oneCorresponding tests are also moved.