Skip to content

chore(onboarding): test the public api of the onboarding snippets in python #91119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

chore(onboarding): test the public api of the onboarding snippets in python #91119

merged 1 commit into from
May 7, 2025

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented May 7, 2025 •
edited
Loading

  • Remove the unused min profiling version export
  • Test getPythonInstallConfig instead of getPythonInstallSnippet
  • Remove export of getPythonInstallSnippet

@shellmayr shellmayr requested review from TkDodo and a team May 7, 2025 11:30
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 7, 2025
TkDodo
TkDodo approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@shellmayr shellmayr mentioned this pull request May 7, 2025
Merged
@shellmayr shellmayr merged commit 6a3eede into master May 7, 2025
43 checks passed
@shellmayr shellmayr deleted the shellmayr/chore/fix-python-install-configs-tests branch May 7, 2025 11:56
andrewshie-sentry pushed a commit that referenced this pull request May 12, 2025
@shellmayr @andrewshie-sentry
chore(onboarding): test the public api of the onboarding snippets in …
641827d 
…python (#91119)
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shellmayr @TkDodo