Cy/step2 codecov onboarding #92432
Cy/step2 codecov onboarding #92432
Conversation
github-actions
bot
added
the
Scope: Frontend
| ); | ||
| } | ||
|
|
||
| const InlineCodeSnippet = styled('span')` |
There was a problem hiding this comment.
I wasn't able to find a way to get the typical CodeSnippet component to achieve this inline sub-snippet look so I styled it separately as I think their functionality is ultimately, inherently different
| @@ -20,6 +24,8 @@ export default function TestsOnboardingPage() { | |||
| }, | |||
| [setSearchParams] | |||
| ); | |||
| const [selectedUploadPermission, setSelectedUploadPermission] = | |||
There was a problem hiding this comment.
Should we move these inside the step component? Or are we expecting these to be used in this component in the near future?
There was a problem hiding this comment.
This value controls what other steps after step 2 are displayed so we'll need it at a higher level
|
|
||
| // HARDCODED VALUES FOR TESTING | ||
| const FULL_TOKEN = '91b57316-b1ff-4884-8d55-92b9936a05a3'; | ||
| const TRUNCATED_TOKEN = '********05a3'; |
There was a problem hiding this comment.
I'm assuming we'll receive the token truncated from the backend yeah?
There was a problem hiding this comment.
Yup, we'll make sure that we do not receive the full token from the backend after generation
| // this value is only used when showing token details | ||
| const [showFullToken, setShowFullToken] = useState(true); | ||
| const [showWarning, setShowWarning] = useState(true); | ||
| const headerText = tct(`Step [step]: add token as [repositorySecret]`, { |
There was a problem hiding this comment.
Step a) is capitalized but b) isn't, could we keep both consistent?
calvin-codecov
force-pushed
the
cy/step2_codecov_onboarding
branch
from
47e21b0 to
90e15df
Compare
Closes https://linear.app/getsentry/issue/CCMRG-145/test-analytics-onboarding-gh-actions-step-2a
Closes https://linear.app/getsentry/issue/CCMRG-144/test-analytics-onboarding-gh-actions-repo-token-step-2b
Closes https://linear.app/getsentry/issue/CCMRG-141/test-analytics-onboarding-gh-actions-oidc-step-2b
Leaves out the expandable bottom section that shows example screenshots as it will be added with https://linear.app/getsentry/issue/CCMRG-1234/ux-test-analytics-onboarding-onboarding-step-expandable-dropdown