fix(dashboards): Update error toast with message #92437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error toasts were putting up generic messages. Update the toasts so the user doesn't have to look at the network tab to explain their problem.
github-actions
bot
added
the
Scope: Frontend
narsaynorath
commented
May 28, 2025
|
|
||
| if ('responseJSON' in e) { | ||
| const response = e.responseJSON; | ||
| if (response?.non_field_errors && Array.isArray(response.non_field_errors)) { |
There was a problem hiding this comment.
This is very special cased right now, but we can expand it out for other errors. I just know this is what the error for the is: filter looks like.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92437 +/- ##
==========================================
- Coverage 78.86% 74.16% -4.71%
==========================================
Files 10226 10226
Lines 585940 585936 -4
Branches 22761 22760 -1
==========================================
- Hits 462120 434572 -27548
- Misses 120401 147946 +27545
+ Partials 3419 3418 -1 |
narsaynorath
deleted the
nar/fix/dashboards-message-user-for-invalid-state
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
The error toasts were putting up generic messages. Update the toasts so the user doesn't have to look at the network tab to explain their problem. This fix is applied to Discover, where at the moment `is:unresolved` results in an error when trying to save a query or save as a homepage. In dashboards this fixes the toast to pick the first error message to display in the toast. This isn't ideal, it would be better if the message appeared with the specific field in the form but for now I wanted to make a quick improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error toasts were putting up generic messages. Update the toasts so the user doesn't have to look at the network tab to explain their problem.
This fix is applied to Discover, where at the moment
is:unresolvedresults in an error when trying to save a query or save as a homepage. In dashboards this fixes the toast to pick the first error message to display in the toast. This isn't ideal, it would be better if the message appeared with the specific field in the form but for now I wanted to make a quick improvement.