Skip to content

🐛 fix(slack): member invite messages #92440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

iamrajjoshi
Copy link
Member

Slack notifications for member invites were not working

the problem was we were passing callback_id in the payload which has been deprecated since we switched to block-kit.
reference: https://api.slack.com/messaging/attachments-to-blocks#callback_id_replacement

we were also trying to send a message to user based on a simple response to the webhook payload which isn't how things work in block kit.

I updated the logic to use the Webhook client to send a notification.

Screen.Recording.2025-05-28.at.1.23.59.PM.mov

There are other places where we use callback_id,
I will make a linear ticket for folks to fix this during triage party based on my fix here

@iamrajjoshi iamrajjoshi self-assigned this May 28, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 28, 2025 20:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/slack/webhooks/action.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92440      +/-   ##
==========================================
+ Coverage   86.55%   87.90%   +1.35%     
==========================================
  Files       10227    10227              
  Lines      586127   586083      -44     
  Branches    22763    22754       -9     
==========================================
+ Hits       507306   515186    +7880     
+ Misses      78392    70468    -7924     
  Partials      429      429              

@iamrajjoshi iamrajjoshi merged commit 77b376e into master May 29, 2025
60 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/fix-member-invite-slack-messages branch May 29, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants