feat(crons/uptime): Move to insights top-level nav #92459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92459 +/- ##
===========================================
+ Coverage 46.25% 87.88% +41.63%
===========================================
Files 10216 10232 +16
Lines 585498 586360 +862
Branches 22785 22783 -2
===========================================
+ Hits 270818 515350 +244532
+ Misses 314250 70580 -243670
Partials 430 430 |
malwilley
reviewed
May 29, 2025
| @@ -1728,11 +1728,6 @@ function buildRoutes() { | |||
| )} | |||
| /> | |||
| </Route> | |||
| <Route path={`${MODULE_BASE_URLS[ModuleName.UPTIME]}/`}> | |||
There was a problem hiding this comment.
I don't think you'll be able to remove these routes completely until the new nav is fully GA'd. You'll need to make sure it still works in the old nav (you can test by toggling it on/off in the help menu).
You can use usePrefersStackedNav() to check which whether or not the new nav is active
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
from
12f0930 to
51e0038
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
from
51e0038 to
3dc4c88
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
from
3dc4c88 to
c4d135a
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
from
c4d135a to
1918b01
Compare
malwilley
reviewed
May 29, 2025
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
from
1918b01 to
b3b6020
Compare
|
Thanks for catching those links. I think this should be everything now 👍 I had to remove a guide anchor that was hiding a button that an acceptance test was clicking because of the fact that the tabs were removed |
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
from
b3b6020 to
a23b407
Compare
malwilley
approved these changes
May 29, 2025
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-uptime-move-to-insights-top-level-nav
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Before this change both Crons and Uptime were hidden under Backend and Frontend inisghts. These are now directly available in the insights secondary nav <img alt="clipboard.png" width="301" src="https://i.imgur.com/0OcoryB.png" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change both Crons and Uptime were hidden under Backend and
Frontend inisghts.
These are now directly available in the insights secondary nav