Skip to content

Arcanization #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Arcanization #49

merged 5 commits into from
Nov 24, 2023

Conversation

nical
Copy link
Contributor

@nical nical commented Nov 24, 2023

No description provided.


## Lifting `RenderPass<'a>` lifetime restrictions

If you have used `wgpu`, there is decent chance that you have had to work around the restrictions imposed by the `'rpass` lifetime in a lot of `RenderPass`'s methods, such as `set_bind_group`, `set_pipeline`, and, `set_vertex_buffer`. The recent changes give us the opportunity to store `Arc`s where `&'a` references were previously needed which should let us remove these lifetime restrictions. A [pull request](github.com/gfx-rs/wgpu/pull/4768) is already open to address this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't mention this PR, it doesn't actually fix the problem, just removes the lifetimes.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cwfitzgerald cwfitzgerald merged commit 3dda3b4 into gfx-rs:master Nov 24, 2023
@a1phyr
Copy link

a1phyr commented Nov 24, 2023

Hi ! Thanks for this blog post !

The images links are broken though.

@cwfitzgerald
Copy link
Member

They should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants