[ll] Heap types and device capabilities #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
changed the title
msiglreith
approved these changes
Jul 19, 2017
| @@ -123,6 +135,8 @@ pub struct Device<R: Resources, F: Factory<R>, Q: CommandQueue> { | |||
| pub transfer_queues: Vec<TransferQueue<Q>>, | |||
| pub heap_types: Vec<HeapType>, | |||
| pub memory_heaps: Vec<u64>, | |||
| /// Device capabilities | |||
| pub caps: Capabilities, | |||
There was a problem hiding this comment.
Could we already have access to these capabilities from Adapter?
So users could have more control about which device to open beside the current AdapterInfo.
There was a problem hiding this comment.
That was my original design, but unfortunately D3D12 only queries those via D3D12Device, which we only get in open(), so I had to move stuff under Device. Anyhow, I'll be happy to revise this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1379
Closes #1381