Skip to content

Encode render targets into the render pass blob #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Feb 10, 2020

Fixes #454

@kvark kvark requested a review from grovesNL February 10, 2020 17:46
@kvark
Copy link
Member Author

kvark commented Feb 10, 2020

Tested on wgpu-rs, it works.

Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grovesNL
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2020
492: Encode render targets into the render pass blob r=grovesNL a=kvark

Fixes #454

Co-authored-by: Dzmitry Malyshau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 11, 2020

Build succeeded

@bors bors bot merged commit e05471a into gfx-rs:master Feb 11, 2020
@kvark kvark deleted the render-pass branch February 11, 2020 14:27
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
492: Replace NonZeroU32 with u32 in TextureViewDescriptor r=kvark a=kunalmohan

Includes gfx-rs#854

(rustfmt seems to have introduced a number of other changes. I can revert them if they are undesired)

r?@kvark

Co-authored-by: Kunal Mohan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode render target information into RawPass
2 participants