Skip to content

server: avoid overwriting Authorization header #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

server: avoid overwriting Authorization header #10859

wants to merge 0 commits into from

Conversation

vesath
Copy link
Contributor

@vesath vesath commented Dec 17, 2024

If no API key is set, leave the Authorization header as is. It may be used by another part of the Web stack, such as an authenticating proxy.

Fixes #10854

@vesath vesath requested a review from ngxson as a code owner December 17, 2024 07:32
ngxson
ngxson requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't push to the fix to this PR, because you made the PR from your master branch.

Here are things to do before this can be merged:

  1. Merge upstream master branch to your PR, because there is a newer change on the UI
  2. Rebuild index.html.gz

@vesath vesath closed this Dec 17, 2024
@vesath vesath mentioned this pull request Dec 17, 2024
Closed
@vesath
Copy link
Contributor Author

vesath commented Dec 17, 2024

I failed to update this PR. Sorry about that. So I created a new one: #10870

@vesath vesath mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson requested changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
2 participants
@vesath @ngxson