Define cache directory on FreeBSD #12892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Apr 11, 2025
| @@ -840,7 +840,9 @@ std::string fs_get_cache_directory() { | |||
| cache_directory = std::getenv("HOME") + std::string("/Library/Caches/"); | |||
| #elif defined(_WIN32) | |||
| cache_directory = std::getenv("LOCALAPPDATA"); | |||
| #endif // __linux__ | |||
| #else | |||
| # error Unknown architecture | |||
There was a problem hiding this comment.
I recently seen people using llama.cpp on AIX, not sure if this will trigger the error on AIX or not
There was a problem hiding this comment.
Hi @ngxson . We have an internal CI and it broke today because of this. I will be contributing a patch to fix it on AIX. Thank you for thinking about us. :)
Lack of cache directory triggers a crash due to an assertion anyway. |
ngxson
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR