Skip to content

Fix RMS norm in GGML #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix RMS norm in GGML #191

merged 1 commit into from
Mar 15, 2023

Conversation

nebulatgs
Copy link
Contributor

Fixes #190

neverabsolute
neverabsolute approved these changes Mar 15, 2023
View reviewed changes
Copy link

@neverabsolute neverabsolute left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been having issues with this since the last release, thanks for fixing 🙏

@hoangmit
Copy link
Contributor

thank for fixing the fix

@hoangmit hoangmit merged commit 9b4a15b into ggml-org:master Mar 15, 2023
blackhole89 pushed a commit that referenced this pull request Mar 15, 2023
@nebulatgs @blackhole89
Fix RMS norm in GGML (#191)
a7b9df2
bitRAKE pushed a commit to bitRAKE/llama.cpp that referenced this pull request Mar 17, 2023
@nebulatgs @bitRAKE
Fix RMS norm in GGML (ggml-org#191)
c727e70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmit hoangmit hoangmit approved these changes

@neverabsolute neverabsolute neverabsolute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new RMS norm PR bricks stuff
3 participants
@nebulatgs @hoangmit @neverabsolute