Llama training finetuning interface #2246
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Jul 21, 2023
There was a problem hiding this comment.
Looks fine, though it's hard to tell what's the best approach.
I see you are applying LoRA at runtime. Can you make a prototype for loading the optional LoRA tensors and measure what is the performance difference compared to applying the LoRA once at the start?
| @@ -242,6 +252,11 @@ extern "C" { | |||
| // IMPORTANT: do not use for anything else other than debugging and testing! | |||
| LLAMA_API int llama_eval_export(struct llama_context * ctx, const char * fname); | |||
|
|
|||
| // Enable finetune on the context, flags indicate what type of finetune | |||
| LLAMA_API int llama_enable_finetune(struct llama_context * ctx, enum llama_finetune_type flags); | |||
There was a problem hiding this comment.
Suggested change
| LLAMA_API int llama_enable_finetune(struct llama_context * ctx, enum llama_finetune_type flags); | |
| LLAMA_API int llama_finetune_enable(struct llama_context * ctx, enum llama_finetune_type flags); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like to get early feedback to adding fine tunning interface to llama.h.
Questions to get feedback: