Server deps.sh unreadable xxd files to string literals. #5221
Conversation
HPP files are much more readable as multiline literals rather than hex arrays.
Replace . and - with _ in file names -> variable names.
XXD-> string literals
Replaced these unreadable headers with string literal versions using new deps.sh.
|
Wow that was quick. Thanks! |
|
This trows compiler |
This reverts commit 4003be0.
|
Ah, so we'll have to stick with the byte arrays then - that's unfortunate |
|
Wait what? This should be a part of the C++11 standard which is how this is compiled. Is your Visual Studio env set to C++ version 11 or up? Please verify as it's a shame to leave this because of an IDE misconfiguration. |
|
@jboero https://developercommunity.visualstudio.com/t/c-string-literal-max-length-much-shorter-than-docu/758957 |
|
That's a shame and odd because VS Code has no such issues. I'd love to chunk it up with the |
We're talking about MSVC here, it's a whole separate compiler developed by Microsoft.
I could try to implement that if you'd like. |
Yes I understand and it's a great IDE actually. If you can find a quick way to do that then great yes. I was thinking of cutting the file up into blocks of 1K or so but that may be unpredictable depending on where the file ends. Open to suggestions. |
* Changed ugly xxd to literals. HPP files are much more readable as multiline literals rather than hex arrays. * Dashes in literal variable names. Replace . and - with _ in file names -> variable names. * Comment on removing xxd. XXD-> string literals * XXD to string literals. Replaced these unreadable headers with string literal versions using new deps.sh.
* Changed ugly xxd to literals. HPP files are much more readable as multiline literals rather than hex arrays. * Dashes in literal variable names. Replace . and - with _ in file names -> variable names. * Comment on removing xxd. XXD-> string literals * XXD to string literals. Replaced these unreadable headers with string literal versions using new deps.sh.
No description provided.