cuda : add half2 __shfl_xor() for ROCm 5.5 #7263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
added
Nvidia GPU
JohannesGaessler
approved these changes
May 16, 2024
|
Based on just static code analysis I approve. Unfortunately I do not have a system set up to test this PR with. Ideally you would get the person that initially reported the issue to confirm that the fix works. @Engininja2 I would still be able to merge this PR without an actual confirmation if I can get a pledge from you that you will take care of any potential follow-up issues that could arise from this PR (just in case, I don't think there will be any). |
|
I tested it with the 5.5 Windows HIP SDK and main compiles & runs okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__shfl_xor()for half2 was added in ROCm 5.6. This PR implements it for HIP versions less than that.Fixes #7242