-
Notifications
You must be signed in to change notification settings - Fork 11.8k
CUDA: deduplicate FlashAttention code #7352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JohannesGaessler
merged 1 commit into
ggml-org:master
from
JohannesGaessler:cuda-fattn-refactor-4
May 18, 2024
Merged
CUDA: deduplicate FlashAttention code #7352
JohannesGaessler
merged 1 commit into
ggml-org:master
from
JohannesGaessler:cuda-fattn-refactor-4
May 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
May 17, 2024
ggerganov
approved these changes
May 18, 2024
3ac059b
to
4d9e90c
Compare
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ggml
changes relating to the ggml tensor library for machine learning
merge ready
indicates that this may be ready to merge soon and is just holding out in case of objections
Nvidia GPU
Issues specific to Nvidia GPUs
refactoring
Refactoring
Review Complexity : High
Generally require indepth knowledge of LLMs or GPUs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7314 .
This PR deduplicates the CUDA FlashAttention code, mainly the code around launching the kernels. For the kernels themselves I only deduplicated the ALiBi slope calculation.
There are also two minor fixes:
parallel_blocks*(Q->ne[1] + cols_per_block - 1) / cols_per_block
instead ofparallel_blocks*((Q->ne[1] + cols_per_block - 1) / cols_per_block)
. I don't think that there is a case on master with which this leads to incorrect results though.