CUDA: fix Pascal FA, deq. KV to FP16 for batch > 8 #7681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check against
__CUDA_ARCH__
for the quantized KV cache is incorrect (> instead of >=). This PR fixes this.It also implements the dequantization of the KV cache for large batch sizes to FP16 in order to make use of the kernels optimized for large batch sizes. I didn't put this into #7527 because I thought it would cause issues for some cases but it seems to be a straight upgrade:
Even at a batch size of 16 dequantizing the KV cache is already faster and the increase in VRAM usage is negligible.
Edit: the numbers are for
-ctk q4_0 -ctv q4_0
.