-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[SYCL] Use multi_ptr to clean up deprecated warnings #8256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Use multi_ptr to clean up deprecated warnings #8256
Conversation
We just fixed the problems that editorconfig is complaining about, so if you update with a rebase or merge with master, you should be able to get a clean bill-of-health on the CI. |
Can you remove the other
|
Thanks for pointing these out. I have addressed the I have not touched the dpct helpers, I am working on a separate PR to clean up some warnings in that. I will include the changes in the second PR, as I want to provide feedback to DPCT and provide an alternative that is independent of llama.cpp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @AidanBeltonS, it's a tidy solution
9865df7
to
4d89e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
70bd412
to
cf94e5d
Compare
This PR adds a
get_pointer()
helper function to use the more up-to-dateget_multi_ptr
.This cleans up build warnings significantly.