server: use relative routes for static files in new UI #8552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jul 18, 2024
ngxson
approved these changes
Jul 18, 2024
|
This seems to break both the old and new web UI in Firefox on Linux (see #8631) . Clicking Start or Send in the UI does not cause inferencing to begin. The web UI continues to work in Chromium on Linux. |
|
@ScarletEmerald I'm not familiar with the difference between Firefox and Chromium... Are there any network log or console output showing the failed request in Firefox? |
4 tasks
|
I can confirm this is fixed by #8646 :) |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 27, 2024
* server: public: fix api_url on non-index pages * server: public: use relative routes for static files in new UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially #6325 but for the new UI (index-new.html); not much to explain.
For non-index pages (new UI being the case), both
document.baseURIandlocation.pathnamewould contain the file name, thus the current way of settingapi_urlwould produce wrong results. This issue is also fixed.