llama.vim : add classic vim support #9995
Conversation
m18coppola
commented
Oct 22, 2024
•
m18coppola
commented
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
m18coppola
changed the title
|
Testing with Vim 9.1, the first call to Also the async jobs seem to create many scratch buffers with the following contents:
|
|
@ggerganov I fixed the scratch buffer issue, it was due to a bad option for the |
|
Both issues are fixed now. |
ggerganov
changed the title
|
@m18coppola Thanks for implementing the classic Vim support! In case you are using this plugin, would appreciate any feedback about issues or ideas to improve it. So far, I think the biggest drawback compared to the original GH copilot is that it tends to over-suggest in certain situations (i.e. repeats lines that are in the suffix). The indentation logic helped a lot to limit this, but it seems that there is still something missing. Not sure if the sampler has to be improved in some way or if it is a model problem. Anyway, if you have any thoughts, let me know. |
* added classic vim support * fixed ring update, removed blank line * minor * minor * minor doc update * removed uneeded var * minor * minor * fixed job_start creating new scratch buffers * fixed job_start creating new scratch buffers * fixed ghost text indenting when expandtab is on * removed unused code * minor * unified fim_on_exit * minor * vim ghost text rendering now uses pos_x and pos_y parameters * renamed *_hlgroup to hlgroup_* * renamed *_ghost_text to ghost_text_*, moved nvim/vim detection to llama#init() * minor --------- Co-authored-by: Michael Coppola <[email protected]>
* added classic vim support * fixed ring update, removed blank line * minor * minor * minor doc update * removed uneeded var * minor * minor * fixed job_start creating new scratch buffers * fixed job_start creating new scratch buffers * fixed ghost text indenting when expandtab is on * removed unused code * minor * unified fim_on_exit * minor * vim ghost text rendering now uses pos_x and pos_y parameters * renamed *_hlgroup to hlgroup_* * renamed *_ghost_text to ghost_text_*, moved nvim/vim detection to llama#init() * minor --------- Co-authored-by: Michael Coppola <[email protected]>
