Skip to content

ci: use hosted Windows/ARM64 runners and extend ci-artifacts again #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025

Conversation

dscho
Copy link
Member

@dscho dscho commented Apr 15, 2025

Now that we can finally play with hosted Windows/ARM64 runners, it is time to switch away from our clunky home-grown solution (which, to be fair, served us very well hitherto).

This also finally opens the door to build Git and run its test suite as part of regular CI builds (without threatening to break my Azure quota). So let's do that.

@dscho
Copy link
Member Author

dscho commented Apr 15, 2025

The check-for-missing-dlls job failed, but that's because it never worked for ARM64. I think we can fix that outside of this PR.

@dennisameling
Copy link
Collaborator

Thanks for setting this up! Exciting to see that hosted runners are finally available! From the failing build:

In file included from ./git-compat-util.h:438:
./compat/bswap.h:133:4: error: "Cannot determine endianness"
  133 | #  error "Cannot determine endianness"
      |    ^

I think I saw this before early on in the ARM64 journey and I just had to set some flags to get it to work again. I'm really short on time until Friday, but otherwise happy to take a look by then if nobody has bandwidth before that.

@dscho dscho force-pushed the use-hosted-windows-arm64-runners branch 5 times, most recently from 5267e92 to 0f8cd86 Compare April 15, 2025 11:14
@rimrul
Copy link
Member

rimrul commented Apr 15, 2025

Thanks for setting this up! Exciting to see that hosted runners are finally available! From the failing build:

In file included from ./git-compat-util.h:438:
./compat/bswap.h:133:4: error: "Cannot determine endianness"
  133 | #  error "Cannot determine endianness"
      |    ^

I think this also gives us a big hint what's going wrong.

crtdefs.h:10: 

C:/a/git-sdk-arm64/git-sdk-arm64/minimal-sdk/clangarm64/include/corecrt.h:128:2: error: You cannot use 32-bit time_t (_USE_32BIT_TIME_T) with _WIN64 

128 | #error You cannot use 32-bit time_t (_USE_32BIT_TIME_T) with _WIN64

That seems like we're ending up in the wrong branch of config.mak.uname.

@dscho dscho force-pushed the use-hosted-windows-arm64-runners branch from 0f8cd86 to 993d065 Compare April 15, 2025 11:56
@dscho
Copy link
Member Author

dscho commented Apr 15, 2025

Thanks for setting this up! Exciting to see that hosted runners are finally available! From the failing build:

In file included from ./git-compat-util.h:438:
./compat/bswap.h:133:4: error: "Cannot determine endianness"
  133 | #  error "Cannot determine endianness"
      |    ^

I think this also gives us a big hint what's going wrong.

crtdefs.h:10: 

C:/a/git-sdk-arm64/git-sdk-arm64/minimal-sdk/clangarm64/include/corecrt.h:128:2: error: You cannot use 32-bit time_t (_USE_32BIT_TIME_T) with _WIN64 

128 | #error You cannot use 32-bit time_t (_USE_32BIT_TIME_T) with _WIN64

That seems like we're ending up in the wrong branch of config.mak.uname.

Indeed. Before upstream Git's master can even so much as build on Windows/ARM64 (using the clangarm64 toolchain), we have to contribute git-for-windows/git@e6aed4b (for the bswap error) and git-for-windows/git@551cfe6 (for the 32-bit time_t one).

@dscho dscho force-pushed the use-hosted-windows-arm64-runners branch from 993d065 to 702fd18 Compare April 15, 2025 12:13
@dscho dscho changed the title ci: use hosted Windows/ARM64 runners ci: use hosted Windows/ARM64 runners and extend ci-artifacts again Apr 15, 2025
@dscho
Copy link
Member Author

dscho commented Apr 20, 2025

This will require git-for-windows/git#5586 to be merged first.

dscho added a commit to git-for-windows/git that referenced this pull request Apr 21, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added 4 commits April 21, 2025 14:18
We waited a long time for this. A loooooong time. And then even longer.
But all good things must end (and likewise not-so-good-ones), as they
say, and as of April 14th, 2025, the hosted Windows/ARM64 runners are
finally ~~available~~in public preview, as announced in:
https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/

So let's use 'em.

Signed-off-by: Johannes Schindelin <[email protected]>
Let's stick to Git's conventions _not_ to use DOS line endings in the
tracked text files whenever possible.

Signed-off-by: Johannes Schindelin <[email protected]>
Git's build definition assumes that the program that excludes unneeded
parts from executables is called `strip.exe`, not `llvm-strip.exe`. So
let's not only include the latter, but also the former, in the
`minimal-sdk` artifact.

Signed-off-by: Johannes Schindelin <[email protected]>
Now that Git for Windows no longer needs to rely on Azure VMs in my
personal Azure account to run the Windows/ARM64 automation, it is time
to "un-drop" the more expensive parts of the `ci-artifacts` workflow
that had not been ported from the x86_64 flavor to the aarch64 one.

In fact, this is more than just a revert because the x86_64 flavor has
seen dramatic improvements, e.g. refactoring running the test suite into
a reusable workflow.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the use-hosted-windows-arm64-runners branch from 702fd18 to 00d4e27 Compare April 21, 2025 12:18
dscho added 2 commits April 21, 2025 15:12
... and pass `build-options` for more information.

Signed-off-by: Johannes Schindelin <[email protected]>
Upstream Git is not ready yet to build on Windows/ARM64. Only once
gitgitgadget/git#1904 will trickle down to
upstream's default branch will that be the case.

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to git-for-windows/git that referenced this pull request Apr 30, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request Apr 30, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request Apr 30, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request May 1, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request May 1, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 1, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 1, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 1, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 3, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 6, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 6, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 8, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request May 8, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request May 8, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 8, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 8, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 8, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 9, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 9, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 9, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 12, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 13, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request May 14, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 14, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 14, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 15, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 16, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
git-for-windows-ci pushed a commit to git-for-windows/git that referenced this pull request May 19, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
dscho added a commit to git-for-windows/git that referenced this pull request May 20, 2025
I encountered these issues that had hitherto escaped us [when I worked
on letting the `ci-artifacts` workflow in git-sdk-arm64 also build Git
and run the test
suite](git-for-windows/git-sdk-arm64#37) by way
of validating the `minimal-sdk` artifact.

Mind, this PR does not only adjust a test case that was previously too
fixated on x86_64. There are two real issues that this PR addresses and
that were found via the test suite:

- When the environment variable `MSYSTEM` is not yet set, it now is set
appropriately even on Windows/ARM64 (and the `PATH` is adjusted
accordingly).
- The tree traversal limit designed to avoid stack overflows needed to
be adjusted for the clangarm64 builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants